feat: Rename future::empty to pending and add stream::pending
#1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marwes
changed the title
future::empty to pending and add stream:Lpendingfuture::empty to pending and add stream:pending
Fixes the inconsistency between `future::empty` and `stream::empty`. I went with `pending` over `never` since there are already a future called `Never` in the library. Closes rust-lang#1624
Marwes
changed the title
future::empty to pending and add stream:pendingfuture::empty to pending and add stream::pending
taiki-e
reviewed
Jun 27, 2019
| @@ -0,0 +1,29 @@ | |||
| use core::marker; | |||
There was a problem hiding this comment.
This module does not seem to be defined...
Co-Authored-By: Taiki Endo <te316e89@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the inconsistency between
future::emptyandstream::empty.I went with
pendingoverneversince there are already a futurecalled
Neverin the library.Don't know where to put tests for this as the one place that tested
emptyseems to be disabled?Closes #1624